Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put everything in paddle python wheel package enable pip install paddle #3102

Merged
merged 7 commits into from
Aug 7, 2017
Merged

Put everything in paddle python wheel package enable pip install paddle #3102

merged 7 commits into from
Aug 7, 2017

Conversation

typhoonzero
Copy link
Contributor

@typhoonzero typhoonzero commented Jul 28, 2017 •
edited
Loading

Fix #2961

So we can push this paddle wheel package to pypi for users to simple run pip install paddle to install

@helinwang
Copy link
Contributor

helinwang commented Jul 28, 2017 •
edited
Loading

Amazing!!! CI failed, please rebase / pull with the latest develop which contains the fix.

@typhoonzero
Copy link
Contributor Author

typhoonzero commented Jul 31, 2017 •
edited
Loading

@helinwang CI fixed. And if we are going to make pushing whl packages to pypi.python.org by ci, how can we separate cpu and gpu versions, and also separate binaries for Linux and MacOS?

gangliao
gangliao reviewed Jul 31, 2017
View reviewed changes
python/setup.py.in Outdated
},
scripts=['${PROJ_BINARY_ROOT}/paddle/scripts/paddle'],
data_files=[('/usr/local/opt/paddle/bin',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumping all binaries into wheel package will make it too large. Why we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then people can just run pip install paddle to install paddle.

@helinwang
Copy link
Contributor

helinwang commented Aug 2, 2017 •
edited
Loading

@typhoonzero did some search. For different binary for linux and mac, seems we need to build "platform wheel" (run python setup.py bdist_wheel on every target platforms): https://packaging.python.org/tutorials/distributing-packages/#platform-wheels . Do we currently need to support mac?

I think we need to have different pip package name for GPU and CPU only. E.g., tensorflow uses:

 $ pip install tensorflow      # Python 2.7; CPU support (no GPU support)
 $ pip install tensorflow-gpu  # Python 2.7;  GPU support

gangliao
gangliao approved these changes Aug 3, 2017
View reviewed changes
Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit 36ac89b into PaddlePaddle:develop Aug 7, 2017
@typhoonzero typhoonzero mentioned this pull request Aug 8, 2017
Merged
@typhoonzero typhoonzero deleted the enable_pip_install_paddle branch August 11, 2017 06:52
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@yghstill
fix batch_size when trt infer (PaddlePaddle#3102)
a066364 
* fix batch_size when trt infer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangliao gangliao gangliao approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@typhoonzero @helinwang @gangliao